-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API changelog eventbrite. #23
base: master
Are you sure you want to change the base?
Conversation
settings/Eventbrite.setting.php
Outdated
// Omitting this line causes the setting to be omitted from the Settings form: | ||
// 'quick_form_type' => 'Element', | ||
// adding it back to implement the new api. | ||
'quick_form_type' => 'Element', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harshal6 This has the effect of making the 'Eventbrite API Organization ID' setting editable by the site admin, but I'm not sure this is advisable. The extension operates under the assumption that the given 'Eventbrite Personal OAuth Token' is only in use for one organization, and it then sets the 'Eventbrite API Organization ID' setting automatically. Have you found some need to edit this value manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no specific need, initially I did not realise we had organization which was autopopulated so made it editable, let me update the code and make it non editable. @twomice thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the PR and made the organization id uneditable.
settings/Eventbrite.setting.php
Outdated
// Omitting this line causes the setting to be omitted from the Settings form: | ||
// 'quick_form_type' => 'Element', | ||
// adding it back to implement the new api. | ||
'quick_form_type' => 'Element', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no specific need, initially I did not realise we had organization which was autopopulated so made it editable, let me update the code and make it non editable. @twomice thanks
Thanks @harshal6 . Tell me please, what steps have you taken to verify that this PR has the desired effect? Specifically, it would be very helpful if you have a moment to answer these basic questions: Before: After: Technical Details: Comments: Whatever information you can provide for the above sections will be very helpful to us in performing the review before merging. We can of course do all this ourselves here, but the above information from you will definitely speed things along. Thanks! |
Before
Technical Requirements Comments Basically I did not test this |
FYI. I found this solution and it worked for me. Got it running for a live event. I did encounter some problems with the integration that are probably not related to this change.
|
Thanks for the confirmation @axelady . I'm ready to merge this but I think the code needs some simple fixes to meet CiviCRM Coding Standard. I'm trying to make time for that soon. Regarding your other two points: If you could create separate issues for these 2 problems it would help us to track them. I can tell you that at the moment this extension is not being used by our clients, so it's hard for us to make time to address these issues, but we'd at least like to a) make people aware of the limitations and b) review and accept PRs to address those issues. |
Not to hijack this thread but I'd be greatly curious to know how @axelady got the integration to work. We made the changes noted above but we are still seeing the 403 error; curiously, we can pull in the ticket options from the event (which suggests it's correctly connecting to some extent) but cannot pull in the current registrants from EB. |
@lcarterBOT I grabbed some screenshots and tried to document here: https://www.dropbox.com/s/2vcf0s6f36r9tbq/SETUP.docx?dl=0 |
@axelady Thank you very much - this is really great and I appreciate your taking the time to put this together. One additional question: is the scheduled job correctly importing participants and registrations back into Civi for you? That's the remaining piece for us - we can see the event and connect to the ticket options, but no registrations are being brought back in. |
@axelady Thanks very much for providing that document. I'd like to attach the document directly to this PR (so that it's still available if and when it's no longer on Dropbox), and possibly integrate its content into the extension docs. Are you agreeable to that? |
@lcarterBOT Yes, it imported participants and registrations, with the errors that I mentioned above (filed issues for each). We also use the civiquickbooks extension and the registration payments pushed nicely into quickbooks from there. I don't recall having done anything with the scheduled job, here's a screenshot of those settings: Also, my cron is set at every 10 mins. |
Changed the /webhook to /organizations/{organization_id}/webhooks