This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Bugfix: If we have problems processing something, don't kill the watch thread. #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dposada
suggested changes
Oct 30, 2019
| (try | ||
| (process kcc pod-name) | ||
| (catch Exception e | ||
| (log/error e "Error while processing pod-update for" pod-name)))))))) |
There was a problem hiding this comment.
Can we include the compute cluster name in this log? To be consistent with other spots, let's do
In compute cluster $name, error while processing pod update for ...
| (try | ||
| (process kcc pod-name) | ||
| (catch Exception e | ||
| (log/error e "Error while processing pod-deleting for" pod-name)))))) |
There was a problem hiding this comment.
Can we include the compute cluster name in this log? To be consistent with other spots, let's do
In compute cluster $name, error while processing pod deletion for ...
dposada
approved these changes
Oct 30, 2019
|
Will merge when green |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Why are we making these changes?
On startup, this processing happens in the watch thread. An exception here causes the watch thread to die, and we don't see new events from kubernetes.