This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Additional file to .dockerignore. #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cook jar is built within the docker image, so there's no need to copy the for-local-invocation cook jar into the docker image. It just bloats it.
shamsimam
previously approved these changes
Nov 8, 2019
shamsimam
reviewed
Nov 8, 2019
|
Yes. However, that file is created when we uberjar in the Dockerfile, and is copied into place afterwards. https://github.com/twosigma/Cook/blob/master/scheduler/Dockerfile#L49 |
shamsimam
approved these changes
Nov 8, 2019
|
Awaiting green build and appropriate label. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Why are we making these changes?
The cook jar is built within the docker image, so there's no need to copy
the for-local-invocation cook jar into the docker image. It just bloats it.