This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
cs: improves the dru/init-user->dru-divisors performance …
#742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschorf
reviewed
Feb 28, 2018
scheduler/src/cook/mesos/share.clj
Outdated
| [?r :resource/amount ?a]] | ||
| datomic-resource-types (map resource-type->datomic-resource-type types) | ||
| default-type->share (pc/map-from-keys | ||
| (fn [type] (get type->share type Double/MAX_VALUE) ) |
dposada
approved these changes
Feb 28, 2018
…datomic queries from share/get-share
shamsimam
force-pushed
the
optimize-init-user-dru-divisors
branch
from
81bb908
to
1893e6f
Compare
pschorf
approved these changes
Feb 28, 2018
dposada
pushed a commit
to dposada/Cook
that referenced
this pull request
Nov 1, 2018
…mic queries from share/get-share (twosigma#742)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…by making fewer datomic queries from
share/get-shareChanges proposed in this PR
share/get-share-by-typeswhich makes a single query to load shares for a userWhy are we making these changes?
For 250 users, reporting last time of 10 iterations and using in-memory db and 10K running tasks and 25K pending jobs
Before:
Elapsed time: 366.445606 msecs(With a datomic connection backed by persistent storage this number is between 3 to 5 seconds)After:
Elapsed time: 163.840391 msecsThe 2-3X improvement is expected as it is making 2-3X fewer DB queries.
There are existing unit tests verifying this change in
cook.test.mesos.share/test'.