-
Notifications
You must be signed in to change notification settings - Fork 63
Removes utilization check from rebalancer #887
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,10 +111,6 @@ We'll look at the configurable options in turn: | |
This option sets the Mesos master connection string. | ||
For example, if you are running Mesos with a Zookeeper node on the local machine (a common development setup), you'd use the connection string `zk://localhost:2181/mesos`. | ||
|
||
`:master-hosts`:: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think it is worthwhile to have a deprecated or removed section in our config doc so users who upgrade aren't confused why the setting they used to use is no longer documented. Perhaps as an alternative, having the init in the scheduler print that the config is no longer used? I don't think it is a big deal so I'm kind of on the fence about it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like the idea of printing that it's no longer used. I will add that. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
This configures a list of hosts where Mesos master are running on. For example `["zk1.example.com", "zk2.example.com", "zk3.example.com"]`. + | ||
When not set explicitly, Mesos master hosts are derived from Mesos master connection string. For example, if the connection string is `"zk://zk1.example.com:2181,zk2.example.com:2181,zk3.example.com:2181/mesos"`, master hosts will be set to `["zk1.example.com", "zk2.example.com", "zk3.example.com"]`. | ||
|
||
`:failover-timeout-ms`:: | ||
This options sets the number of milliseconds that Mesos will wait for the Cook framework to reconnect. | ||
In development, you should set this to `nil`, which means that Mesos will treat any disconnection of Cook as the framework ending; this will kill all of Cook's tasks when it disconnects. | ||
|
@@ -260,9 +256,6 @@ Optionally, you can include a "rebalancer" stanza. If you do, on startup, Cook | |
:max-preemption:: | ||
See the link:rebalancer-config.adoc[Rebalancer documentation] | ||
|
||
:min-utilization-threshold:: | ||
See the link:rebalancer-config.adoc[Rebalancer documentation] | ||
|
||
`:dru-scale`:: | ||
This is only used to control the metrics reporting of DRU values. On some clusters, | ||
the DRU's may be so small that when the values are fed to clj-metrics, they are | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it ok to assume localhost here? I'm imagining a case where you run the integration tests on a production cluster and then the tests that check the number of hosts. What am I missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, this is only a decent assumption when running locally. For other environments, we will have to set the
COOK_MESOS_LEADER_URL
environment variable (see 3 lines above).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ha! That is what I was missing. Thanks, I knew it was something stupid on my part.