WIP #6688 dark theme and #6687 font in lab #7454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asz/6687_6688_font_and_dark_theme
…_6688_font_and_dark_theme
…_6688_font_and_dark_theme
…_do_not_relly_on_bootstrap_css
…_do_not_relly_on_bootstrap_css
…_do_not_relly_on_bootstrap_css
…_6688_font_and_dark_theme
…m:twosigma/beakerx into lukasz/6687_6688_font_and_dark_theme
…_6688_font_and_dark_theme
|
cool, looks great! a few problems i found: |
|
plots missing resize thumb |
|
table sorted column |
|
and definitely bring up to date with master before working on the spark UI, all that stuff has changed... |
…_6688_font_and_dark_theme
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tree ui
plots
data grid
foldouts
spark ui
menus in plot and data grid
Data grids styles after sorting
spark ui style after connecting (alignment is off)
plot text item color (see coments below)
resize thumb missing in plots
check fonts