Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result returns corners of scanned code. #107

Merged
merged 1 commit into from
May 8, 2023
Merged

Result returns corners of scanned code. #107

merged 1 commit into from
May 8, 2023

Conversation

richy486
Copy link
Contributor

@richy486 richy486 commented May 7, 2023

So we can draw a cool shape around the tracked code.

nathanfallet
nathanfallet previously requested changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@nathanfallet nathanfallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an optional CGRect instead of an array of CGPoints would be better

@nathanfallet nathanfallet dismissed their stale review May 8, 2023 08:36

Updating it

@nathanfallet nathanfallet merged commit 5b2c9b0 into twostraws:main May 8, 2023
@richy486
Copy link
Contributor Author

richy486 commented May 9, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanfallet nathanfallet nathanfallet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richy486 @nathanfallet