Add support to update jobs, if they exist. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional argument to create_copy(), to indicate whether to update the job if it already exists.
|
I would like to see the update feature added to autojenkins. If you think this should be done as a separate API, then I will submit this as a separate API ... |
|
This seems OK to me, I'll take a look in detail when I get more time. |
|
The only problem that I see with this approach is, it will break existing users if they have a variable called "update" in their template. |
|
Good point. Maybe you can solve that (make it less likely) if you rename that parameter with a leading underscore, such as |
In create_copy(), use the argument name _force, instead of update, to avoid collision with other template variable names. Also added a unit test case to cover this scenario.
txels
added a commit
that referenced
this pull request
Oct 12, 2014
Add support to update jobs, if they exist.
|
Thanks! This will be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional argument to create_copy(), to indicate whether to
update the job if it already exists.