Readfile: Fix exception type for STDIN reading #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This specific line was introduced in txt2tags version 1.0, from 2002. By that time, every exception used to have `Exception` as the root class, so this used to work for the use-case of hitting Control-C when txt2tags seemed frozen (but in fact was just waiting for data in STDIN). In recent Python 2.7 and 3.x, `KeyboardInterrupt` is derived from `BaseException` instead, so this is not catching Control-C anymore. The fix is simple: use the specific `KeyboardInterrupt` exception instead of a generic one (sorry, in 2002 I did not know better).
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This specific line was introduced in txt2tags version 1.0, from 2002. By
that time, every exception used to have
Exceptionas the root class,so this used to work for the use-case of hitting Control-C when txt2tags
seemed frozen (but in fact was just waiting for data in STDIN).
In recent Python 2.7 and 3.x,
KeyboardInterruptis derived fromBaseExceptioninstead, so this is not catching Control-C anymore.The fix is simple: use the specific
KeyboardInterruptexceptioninstead of a generic one (sorry, in 2002 I did not know better).