Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update txt2tags.py #224

Merged
merged 28 commits into from Feb 14, 2020
Merged

Update txt2tags.py #224

merged 28 commits into from Feb 14, 2020

Conversation

goetzschnell
Copy link

added target ConTeXt (ctx),
topics to discuss eventually:

  • escaping
  • some rules
  • output (layout and design of ConTeXt output)

added target ConTeXt (ctx)
Copy link

@jendrikseipp jendrikseipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run "black" on the Python file to fix the style tests. Also, please run "./txt2tags.py -t ctx samples/sample.t2t" and add the resulting file to the repo. Please check that the file can be compiled and that it looks as expected (source ctx file and the resulting PDF). Before we can merge this, all tests have to pass.

txt2tags.py Outdated
@@ -82,7 +82,7 @@
my_url = "https://txt2tags.org"
my_name = "txt2tags"
my_email = "jendrikseipp@gmail.com"
__version__ = "3.7"
__version__ = "3.7.1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change the version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eliminated

txt2tags.py Outdated
"""
""",
"ctx": \
r"""%% created from txt2tags

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eliminated

@goetzschnell
Copy link
Author

eliminated version and comment,
added samples/sample.ctx and samples/sample.pdf
ran run.py, added run.pyc in every test folder
result of run.py:
2020-02-12result.txt

Copy link

@jendrikseipp jendrikseipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the binary files again (*.pyc, *.pdf).

@goetzschnell
Copy link
Author

eliminated sample.pdf
eliminated *.pyc

@jendrikseipp jendrikseipp merged commit b6cb7af into txt2tags:v3 Feb 14, 2020
@jendrikseipp
Copy link

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants