Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatched theme options #176

Merged
merged 4 commits into from
Dec 25, 2022
Merged

Conversation

Facinorous-420
Copy link
Contributor

@Facinorous-420 Facinorous-420 commented Nov 29, 2022

Checklist

  • I have read the [Contributing Guidelines]
  • I acknowledge that any submitted code will be licensed under the [ISC License]
  • I confirm that submitted code is my own work
  • I have tested the code, and confirm that it works

Environment

  • Operating System: Windows 11
  • Node version: v18.12.1
  • npm version: v8.19.2

Description

I have fixed the txtPrimary and txtSecondary classes to be on the correct text in the index view.
Along with this, since the old links used txtPrimary I have added a linkPrimary class which will represent the base link colour before any other effects take place.

The default ass colour scheme is still in place and works with this PR.

Recommended

For further additions to this theming, I would suggest adding a txtTertiary class which will represent the ad text colour. or the size text colour.
I did not include this though as that is on your discretion to add.

- Add linkPrimary class for link colour
@tycrek tycrek changed the base branch from master to 0.14.0/stage November 30, 2022 05:17
@tycrek
Copy link
Owner

tycrek commented Nov 30, 2022

Updated base to https://github.com/tycrek/ass/tree/0.14.0/stage

@tycrek tycrek added this to the 0.14.0 milestone Nov 30, 2022
@tycrek tycrek changed the title - Fix txtPrimary & txtSecondary class positions - Added linkPrimary class Fix mismatched theme options Nov 30, 2022
@tycrek tycrek merged commit a80d15f into tycrek:0.14.0/stage Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants