[ZEPPELIN-4341] update SecurityUtils#getRoles to catch errors so if m…

…ultiple realms they will all be attempted
tylerba-f · Sep 27, 2019 · ad26443 · ad26443
1 parent e2e1d19
commit ad26443
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/utils/SecurityUtils.java b/zeppelin-server/src/main/java/org/apache/zeppelin/utils/SecurityUtils.java
@@ -158,8 +158,12 @@ public static HashSet<String> getRoles() {
             if (auth != null) {
               roles = new HashSet<>(auth.getRoles());
             }
-          } catch (NamingException e) {
-            log.error("Can't fetch roles", e);
+          } catch (Throwable t) {
+            if (log.isDebugEnabled()) {
+              String msg = "Realm [" + realm +
+                           "] threw an exception during a multi-realm authorization attempt:";
+              log.debug(msg, t);
+            }
           }
           break;
         } else if (name.equals("org.apache.zeppelin.realm.ActiveDirectoryGroupRealm")) {