Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section position set on creation and update, merging of duplicate sections #1103

Merged
merged 17 commits into from
Oct 14, 2015
Merged

Section position set on creation and update, merging of duplicate sections #1103

merged 17 commits into from
Oct 14, 2015

Conversation

UnspeakableHorror
Copy link
Collaborator

Fixes #1102.
Fixes #1079.
Fixes #1064.

  • Moved logic about setting a section position on creation or update.
  • Fixed bug where a section would be set as first on creation even though there was one already present.
  • Fixed duplicate positions on test script. (Sorry).
  • Added merging of duplicate sections for: Summary, Skills and Career Interests on creation and update.
  • Refactored addition of Contact data for Comments and Section Advice..

@UnspeakableHorror UnspeakableHorror self-assigned this Oct 9, 2015
@UnspeakableHorror UnspeakableHorror added this to the 2015-10-16 milestone Oct 9, 2015
@natebenson natebenson deployed to vyllage-pr-1103 October 9, 2015 04:00 Active
@natebenson natebenson deployed to vyllage-pr-1103 October 9, 2015 04:13 Active
@natebenson natebenson deployed to vyllage-pr-1103 October 9, 2015 04:17 Active
@UnspeakableHorror
Copy link
Collaborator Author

I'm going to include #1079 and #1064 here too.

@natebenson natebenson deployed to vyllage-pr-1103 October 9, 2015 12:40 Active
@natebenson natebenson deployed to vyllage-pr-1103 October 9, 2015 12:47 Active
@UnspeakableHorror
Take into account Summary Section.
58884c5 
If the section being edited is the Summary section then set it's
position to 1 just in case it was changed.
@UnspeakableHorror
Added Mergeable interface and implementation for sections that can be
1431a8e 
merged.
Added rule to merge duplicate sections of same type when they are single
section only.
Tests.
@UnspeakableHorror UnspeakableHorror changed the title Fixes section position set on creation and update Fixes section position set on creation and update, merging of duplicate sections Oct 10, 2015
@UnspeakableHorror UnspeakableHorror changed the title Fixes section position set on creation and update, merging of duplicate sections Section position set on creation and update, merging of duplicate sections Oct 10, 2015
@natebenson natebenson deployed to vyllage-pr-1103 October 10, 2015 03:21 Active
@natebenson natebenson deployed to vyllage-pr-1103 October 13, 2015 16:32 Active
@UnspeakableHorror
Fixed mege bugs.
1a5c902 
Added tests.
@natebenson natebenson deployed to vyllage-pr-1103 October 14, 2015 01:22 Active
@natebenson natebenson deployed to vyllage-pr-1103 October 14, 2015 01:23 Active
@UnspeakableHorror
Copy link
Collaborator Author

The backend no longer allows changing the position of the Summary Section.
The frontend should be changed to remove the ordering handle from the Summary Section.

@UnspeakableHorror
Copy link
Collaborator Author

For the existing duplicate sections once the user edits them they will be merged automatically but he will have to hit refresh to update the page or try to edit/create and save one, that will generate an error on the backend complaining that someone tried to edit a non existing section which is fine.

@natebenson natebenson deployed to vyllage-pr-1103 October 14, 2015 04:47 Active
@natebenson natebenson deployed to vyllage-pr-1103 October 14, 2015 04:53 Active
@tylerbenson
Copy link
Owner

Wow, good work. Didn't realize how involved this was going to be.

@tylerbenson
Copy link
Owner

Please create an issue for the front end to remove the move for summary.

tylerbenson added a commit that referenced this pull request Oct 14, 2015
@tylerbenson
Merge pull request #1103 from natebenson/carlos/fix-section-position-set
230b91f 
Section position set on creation and update, merging of duplicate sections
@tylerbenson tylerbenson merged commit 230b91f into master Oct 14, 2015
@tylerbenson tylerbenson deleted the carlos/fix-section-position-set branch October 14, 2015 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tylerbenson tylerbenson

Labels
back end bug ready for review
Projects
None yet
Milestone
2015-10-16
Development

Successfully merging this pull request may close these issues.
3 participants
@UnspeakableHorror @tylerbenson @natebenson