Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asString option #190

Merged
merged 7 commits into from Mar 27, 2017
Merged

Add asString option #190

merged 7 commits into from Mar 27, 2017

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2017

boolean optional

Sets state as empty string instead of empty Object or Array if there is no Firebase data.

  • Added a validator: cannot be used in conjunction with isNullable or asArray
  • Added tests for fetch, bindToState, syncState and they are passing

Idea behind the pull request: React emits a warning if an input is null, see react#6996. I was using isNullable and incurred in the warning while syncingState. I was about to open an issue, but… :)

Sets state as empty string instead of empty Object or Array if there is no Firebase data
Added as asString option, tests passing
@qwales1 qwales1 merged commit 10bdff5 into tylermcginnis:master Mar 27, 2017
@qwales1
Copy link
Collaborator

qwales1 commented Mar 27, 2017

@flagello Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants