Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chat overlap #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix chat overlap #16

wants to merge 1 commit into from

Conversation

milouk
Copy link

@milouk milouk commented Mar 12, 2022

No description provided.

@milouk milouk force-pushed the master branch 7 times, most recently from 77fdf70 to c7ea873 Compare March 13, 2022 14:45
@igorcafe
Copy link
Contributor

igorcafe commented Apr 6, 2022

Can you show a screenshot of the issue just to make it clearer?

@tymmesyde
Copy link
Owner

Hi !
Can you separate your changes into different pr ?

@milouk
Copy link
Author

milouk commented May 2, 2022

Hi ! Can you separate your changes into different pr ?

Done. The reset of the changes where in order to deploy my own version.

@tymmesyde
Copy link
Owner

Thank you !
I tested these changes but i fail to see what it fixes, it seems to be breaking the chat on mobile

@milouk
Copy link
Author

milouk commented May 9, 2022

well, after a re-check, the issue should not be present in mobile but it exists in desktop mode.

Here you can see what is currently being deployed. As you can see if anyone opens the chat the movie is being overlapped leading to an either chatting or watching experience
Screenshot 2022-05-09 at 10 02 28

With my change this is what happens
Screenshot 2022-05-09 at 10 03 43

** Obviously i haven't tested my change in mobile, which as you said is broken

@igorcafe
Copy link
Contributor

I tested yesterday or so and it was 100% width.
Tested today and now it looks like your solution.
I believe @tymmesyde fixed it.
image

@zaovb
Copy link

zaovb commented Apr 10, 2023

Hi, I just wanted to tell you that it is still opening fullscreen the chat for me. Tested on 3 diferent devices and browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants