Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving statistics to a file is broken #58

Closed
tyoma opened this issue Apr 14, 2020 · 2 comments
Closed

Saving statistics to a file is broken #58

tyoma opened this issue Apr 14, 2020 · 2 comments

Comments

@tyoma
Copy link
Owner

tyoma commented Apr 14, 2020

Accordingly to the question on Visual Studio Marketplace:

(MSVS 2015) I installed MicroProfiler, and it worked fine for a few days. Then, after a computer restart, it was suddenly missing from my toolbar, and was not listed in Tools -> Extensions and Updates. So I reinstalled it, but now, I can't open MicroProfiler files. I can run a profile, and I can save the results, but I can't open those results. When I try, it says, "Visual Studio has encountered an unexpected error." Any clue what's wrong?

I'm wondering if something updated (like a Windows patch) that broke it, even though I restarted the computer a couple times before it broke. I've also tried uninstalling and reinstalling, deleting files manually and reinstalling, uninstalling and deleting leftover files then reinstalling, uninstalling from both VS2015 and "Add/Remove Programs," everything I could think of. Also, after reinstalling once or twice, now trying to uninstall it from MSVS 2015 doesn't do anything. Like literally nothing happens when I click uninstall. I've even reinstalled MSVS 2015 at this point, and it didn't help.

By Keith M 4/9/2020

@tyoma
Copy link
Owner Author

tyoma commented Apr 14, 2020

There're two things broken: saving accordingly to the new schema (with thread info included) and backward compatibility (i.e. loading files stored before the thread information added to MicroProfiler).

tyoma added a commit that referenced this issue Apr 14, 2020
- serialization schema refactored: functions_list is no longer a container - instead it is serialized using universal serialize routine, that later branches depending on the context.
@tyoma tyoma changed the title Saving to file is broken Saving statistics to a file is broken Apr 14, 2020
@tyoma
Copy link
Owner Author

tyoma commented Apr 15, 2020

Fixed in commit 9adec67. Default extension changed to .mpstat4, while reading of .mpstat3 is supported as well.

@tyoma tyoma closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant