Bring apps closer to typechecking out of the box #1169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, if I run
ember new my-app
and then immediately follow that withember install ember-cli-typescript
, I can almost renameapp.js
,router.js
andtest-helper.js
to end in.ts
and have a typechecking application out of the box. There are still just a couple of blockers for that:app.js
importsember-resolver
but we don't install the@types
package for that by defaulttest-helper.js
referencesconfig.APP
, which isn't part of the declarations we emit forconfig/environment
test-helper.js
includes relative imports forapp
andconfig/environment
that work at runtime but don't match the on-disk layout, so TS rejects the importThis PR aims to fix those first two bullets, and I have an ember-cli PR open to address the third.