Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring apps closer to typechecking out of the box #1169

Merged
merged 4 commits into from
Jul 2, 2020
Merged

Bring apps closer to typechecking out of the box #1169

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aba8f5d
fix(blueprint): bring apps closer to typechecking out of the box
dfreeman Jul 1, 2020
2534377
Merge branch 'master' into typecheck-out-of-the-box
dfreeman Jul 1, 2020
e0dff3a
Merge branch 'master' into typecheck-out-of-the-box
dfreeman Jul 2, 2020
29724e2
Merge branch 'master' into typecheck-out-of-the-box
dfreeman Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions blueprint-files/ember-cli-typescript/__config_root__/config/environment.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@ export default config;

/**
* Type declarations for
* import config from './config/environment'
*
* For now these need to be managed by the developer
* since different ember addons can materialize new entries.
* import config from 'my-app/config/environment'
*/
declare const config: {
environment: any;
environment: string;
modulePrefix: string;
podModulePrefix: string;
locationType: string;
rootURL: string;
APP: Record<string, unknown>;
};
2 changes: 1 addition & 1 deletion ts/blueprints/ember-cli-typescript/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ module.exports = {
{ name: 'ember-cli-typescript-blueprints', target: 'latest' },
{ name: 'typescript', target: 'latest' },
{ name: '@types/ember', target: 'latest' },
{ name: '@types/rsvp', target: 'latest' },
Copy link
Member Author

@dfreeman dfreeman Jul 1, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/ember already brings in @types/rsvp, and having one fewer explicit version constraint floating around makes "cannot re-declare block scoped variables" less likely to crop up as folks update various dependencies.

{ name: '@types/ember__test-helpers', target: 'latest' },
{ name: '@types/ember-resolver', target: 'latest' },
];

if (this._has('ember-data')) {
Expand Down