Add plugin support for apps.get_model()
#1725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to resolve the provided lazy reference to a model type. As such it can now return a specific model depending on what it was called with
|
Interestingly enough the test that is added doesn't fail locally... |
sobolevn
reviewed
Sep 21, 2023
| return None | ||
|
|
||
| # Reference conforms to the structure of a lazy reference: '<app_label>.<object_name>' | ||
| fullname = django_context.model_class_fullnames_by_label_lower.get(reference.lower()) |
There was a problem hiding this comment.
Question about lower: why is that needed?
There was a problem hiding this comment.
The implementation is case insensitive:
Returns the Model with the given app_label and model_name. As a shortcut, this method also accepts a single argument in the form app_label.model_name. model_name is case-insensitive.
Ref: https://docs.djangoproject.com/en/4.2/ref/applications/#django.apps.apps.get_model
I really can't figure out how to reproduce locally.. @sobolevn would you mind checking out and try it, whenever you'd get a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to resolve the provided lazy reference to a model type. As such it can now return a specific model depending on what it was called with
Related issues
Closes: #1318
Closes: #304
Closes: #305
Closes: #814
High value comment/discussion: #814 (comment)