Avoid returning None from get_field_related_model_cls #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingingTree
force-pushed
the
fix-get_field_related_model_cls-returning-none
branch
from
794c44b
to
c4580f9
Compare
sobolevn
reviewed
Feb 19, 2024
yeah I think it would be great to add a test case to |
flaeppe
reviewed
Feb 19, 2024
SingingTree
force-pushed
the
fix-get_field_related_model_cls-returning-none
branch
from
c4580f9
to
bd39874
Compare
|
Updated to shift location of check. I'm open to suggestions re tests. The scenario I'm encountering this in is some proprietary code that I'm yet to reduce to something that nicely fits into a test here. |
SingingTree
force-pushed
the
fix-get_field_related_model_cls-returning-none
branch
from
bd39874
to
7e346e3
Compare
flaeppe
approved these changes
Feb 20, 2024
|
I've been traveling, and will make some time to get my branch updated over the next couple of days. |
SingingTree
force-pushed
the
fix-get_field_related_model_cls-returning-none
branch
from
7e346e3
to
1eef6e2
Compare
|
I've reverted the changes back to the first iteration of PR. I'm afraid I haven't had any luck in reducing the faulting code to a test case. FWIW, the scenario I'm seeing this hit in is using django taggit. I'm not certain what's going on under the hood that's resulting in the unhappiness however. |
sobolevn
approved these changes
Feb 25, 2024
typeddjango#1495 updated `get_field_related_model_cls` to raise `UnregisteredModelError` rather than returning `None` for failure paths. However, None can still be returned if the initial retrieval of `related_model_cls` returns None. This patch adds a check to see if the initial retrieval has got a `None` and then raises the appropriate error rather than letting `None` be returned.
SingingTree
force-pushed
the
fix-get_field_related_model_cls-returning-none
branch
from
1eef6e2
to
23b6aa3
Compare
flaeppe
approved these changes
Feb 25, 2024
jooola
pushed a commit
to libretime/libretime
that referenced
this pull request
May 5, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [django-stubs](https://togithub.com/typeddjango/django-stubs) ([changelog](https://togithub.com/typeddjango/django-stubs/releases)) | `>=1.14.0,<5` -> `>=1.14.0,<6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>typeddjango/django-stubs (django-stubs)</summary> ### [`v5.0.0`](https://togithub.com/typeddjango/django-stubs/releases/tag/5.0.0) [Compare Source](https://togithub.com/typeddjango/django-stubs/compare/4.2.7...5.0.0) #### Announcements - `QuerySet` class no longer derives from `Collection`. If you run into errors like `incompatible type "_QuerySet[User, User]"; expected "Collection[User]"`, [please read this announcement](https://togithub.com/typeddjango/django-stubs/discussions/2095). #### Headline changes - Remove incorrect `Collection` base class and `__contains__` method from `QuerySet` by [@​fidoriel](https://togithub.com/fidoriel) in [typeddjango/django-stubs#1925 - Pyright joins the workflow in an advisory capacity by [@​jorenham](https://togithub.com/jorenham) in [typeddjango/django-stubs#2019 - feat: Allow setting django_settings_module from env by [@​armanckeser](https://togithub.com/armanckeser) in [typeddjango/django-stubs#2021 - Add `ManyRelatedManager.through` attribute and generic type parameter by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#2026 #### What's Changed - Make `StrPromise` not inherit from `Sequence[str]` by [@​intgr](https://togithub.com/intgr) in [typeddjango/django-stubs#1841 - Update and prepare for Django 5.0 by [@​intgr](https://togithub.com/intgr) in [typeddjango/django-stubs#1859 - Ensure mypy plugin processes inherited many to many fields by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#1864 - Include ModelBase subclasses in plugin base class hook condition by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#1863 - \[5.0] Added many new a-prefixed asynchronous methods by [@​bigfootjon](https://togithub.com/bigfootjon) in [typeddjango/django-stubs#1741 - Remove section regarding custom queryset methods from README by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#1865 - Fix type of `AppConfig.models_module` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1866 - Allow `None` in settings `MIGRATION_MODULES` dict values by [@​asottile](https://togithub.com/asottile) in [typeddjango/django-stubs#1871 - Add type hints for `JSONField.from_db_value` by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#1879 - Fix/pyright unknown by [@​dephiros](https://togithub.com/dephiros) in [typeddjango/django-stubs#1873 - Fix type hints of `converters` in `urls.resolvers` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1892 - Update mypy to 1.8.0 by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#1885 - Add `@type_check_only` to all Protocols and known stubs-only classes by [@​intgr](https://togithub.com/intgr) in [typeddjango/django-stubs#1894 - Fix types for UniqueConstraint instantiation by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#1880 - Add `ModuleType` as a possible type to `URLResolver.urlconf_name` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1891 - Fix type hint of `URLPattern.default_args` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1895 - Update ruff and silence `PYI046` by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#1907 - Use PEP 570 syntax by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1908 - Fix readme settings example by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1910 - Fix type hint of `EmailBackend.ssl_keyfile` and `EmailBackend.ssl_certfile` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1911 - Add type of `django.VERSION` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1916 - Added `CommandParser` to `commands.__init__` by [@​jamesbraza](https://togithub.com/jamesbraza) in [typeddjango/django-stubs#1927 - \[5.0] add `assume_scheme` to forms.URLField by [@​asottile](https://togithub.com/asottile) in [typeddjango/django-stubs#1929 - Fix return type of `BaseModelAdmin.formfield_for_dbfield` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1934 - Revert `pre-commit==3.6.1` by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#1936 - Fix type hint of `Response.set_cookie.max_age` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1941 - 5.0: Add ChoicesType by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1942 - Add through_defaults for RelatedManager methods by [@​mfosterw](https://togithub.com/mfosterw) in [typeddjango/django-stubs#1943 - Update type hints of `core.signing` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1945 - \[5.0] Update `core.validators` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1947 - \[5.0] Update `core.paginator` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1946 - Generic `forms.ModelChoiceField` by [@​UnknownPlatypus](https://togithub.com/UnknownPlatypus) in [typeddjango/django-stubs#1889 - Support processing of other relations and fields when one is broken by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#1877 - Allowing `set` in `model_to_dict`'s `exclude` by [@​jamesbraza](https://togithub.com/jamesbraza) in [typeddjango/django-stubs#1952 - \[5.0] Add django.db.models.GeneratedField by [@​palfrey](https://togithub.com/palfrey) in [typeddjango/django-stubs#1944 - Fix type hint of `BaseEngine.template_dirs` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1954 - Update type hints of contrib.auth.hashers by [@​yhay81](https://togithub.com/yhay81) in [typeddjango/django-stubs#1955 - deps: Upgrade pre-commit for newer versions of python by [@​delfick](https://togithub.com/delfick) in [typeddjango/django-stubs#1961 - 5.0: Add auth.middleware.auser by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1966 - 5.0: Add ModelAdmin.show_facets by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1967 - ruff: Fix config warnings by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1964 - 5.0: Add BaseConstraint.violation_error_code by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1969 - 5.0: Add Signal.asend and Signal.asend_robust by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1965 - 5.0: Add QuerySet.(a)update_or_create new create_defaults arg by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1970 - 5.0: Add AdminSite.get_log_entries by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1963 - 5.0: Add gis ClosestPoint by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1968 - 5.0: Rename save_existing arg instance to obj by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1971 - 5.0: Remove admin.helpers.checkbox by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1972 - 5.0: Change annotation_select_mask from set\[str] to list\[str] by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1973 - fixup: Pass violation_error_code to init by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1975 - Avoid returning None from get_field_related_model_cls by [@​SingingTree](https://togithub.com/SingingTree) in [typeddjango/django-stubs#1956 - 5.0: Pass positional args name and violation_error_message to BaseConstraint by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1974 - 5.0: Remove pytz support by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1980 - 5.0: Remove global setting USE_L10N by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1979 - 5.0: Remove OSMGeoAdmin, GeoModelAdmin by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1981 - 5.0: Remove extra_tests arg for DiscoverRunner.build_suite/run_tests by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1978 - 5.0: Remove django.utils baseconv and datetime_safe modules by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1977 - 5.0: Add request arg to ModelAdmin.lookup_allowed by [@​q0w](https://togithub.com/q0w) in [typeddjango/django-stubs#1976 - Add URL converter protocol type by [@​adamchainz](https://togithub.com/adamchainz) in [typeddjango/django-stubs#1984 - Fix type annotation for RegisterLookupMixin.class_lookups by [@​avoronov-box](https://togithub.com/avoronov-box) in [typeddjango/django-stubs#1962 - Update django to 5.0.3 by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#1990 - Remove some deprecated Django 3.x APIs by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#1991 - Fix BaseModelAdmin.view_on_site annotation by [@​cuu508](https://togithub.com/cuu508) in [typeddjango/django-stubs#1993 - Allow immutable `extra_context` on `TemplateView`s by [@​samueljsb](https://togithub.com/samueljsb) in [typeddjango/django-stubs#1994 - Add BoundField.**html**() by [@​pelme](https://togithub.com/pelme) in [typeddjango/django-stubs#1999 - Allow timedelta type for session.set_expiry() argument by [@​mlazar-endear](https://togithub.com/mlazar-endear) in [typeddjango/django-stubs#2001 - Bump `pytest-mypy-plugins` to 3.1.1 by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#2003 - Update mypy, add a bit more metadata by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#1997 - 5.0: Update `django.contrib.auth` by [@​ngnpope](https://togithub.com/ngnpope) in [typeddjango/django-stubs#2009 - 5.0: Update `django.conf` by [@​ngnpope](https://togithub.com/ngnpope) in [typeddjango/django-stubs#2008 - 5.0: Update `django.views` by [@​ngnpope](https://togithub.com/ngnpope) in [typeddjango/django-stubs#2007 - 5.0: Update `django.test` by [@​ngnpope](https://togithub.com/ngnpope) in [typeddjango/django-stubs#2005 - 5.0: Update `django.utils` by [@​ngnpope](https://togithub.com/ngnpope) in [typeddjango/django-stubs#2006 - Specify d.c.serializers.base.DeserializedObject.object type by [@​j00bar](https://togithub.com/j00bar) in [typeddjango/django-stubs#2010 - Clean the cache on each run of `stubtest` by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#2015 - Keep abstract Django models internally in the plugin by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#2017 - Add GitHub actions release workflow by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#1950 - Adding missing `Q` methods: `check()`, `flatten()` by [@​Alexerson](https://togithub.com/Alexerson) in [typeddjango/django-stubs#1899 - Improve types in `utils.termcolors` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1901 - Set the calculated metaclass when creating type info in the plugin by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#2025 - Do not annotate PRs with pyright by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#2023 - Use `PRI_MYPY` in `get_additional_deps` hook by [@​sobolevn](https://togithub.com/sobolevn) in [typeddjango/django-stubs#2024 - Update `_default_manager` and `_base_manager` to be `Manager` by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#2022 - Determine the type of queryset methods on unions by [@​delfick](https://togithub.com/delfick) in [typeddjango/django-stubs#2027 - Add first stub for get_model_admin by [@​nebiyuelias1](https://togithub.com/nebiyuelias1) in [typeddjango/django-stubs#2029 - 5.0: Update `django.contrib.admin` by [@​ngnpope](https://togithub.com/ngnpope) in [typeddjango/django-stubs#2004 - \[5.0] Update `core.files` by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1949 - \[5.0] Update `core.cache.backends`, add `RedisCache` and related classes by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#1948 - Fix `AsyncClient.defaults` attribute typing by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#1878 - Relax type for `fields` argument of `Model.refresh_from_db()` by [@​mthuurne](https://togithub.com/mthuurne) in [typeddjango/django-stubs#2035 - \[5.0] Add missing stubs for geos by [@​nebiyuelias1](https://togithub.com/nebiyuelias1) in [typeddjango/django-stubs#2034 - Make `AdminSite.get_model_admin` generic by [@​Viicos](https://togithub.com/Viicos) in [typeddjango/django-stubs#2038 - \[5.0] Add `db_default=` parameter to models `Field` classes by [@​Skorpyon](https://togithub.com/Skorpyon) in [typeddjango/django-stubs#1876 - Remove `class Meta` from `Model` and `Form` class stubs by [@​jorenham](https://togithub.com/jorenham) in [typeddjango/django-stubs#2000 - Add datetime.timedelta as valid type for HttpRequest.get_signed_cookie() max_age argument. by [@​pelme](https://togithub.com/pelme) in [typeddjango/django-stubs#2045 - CI: Update Django 4.2 version used for test suite by [@​intgr](https://togithub.com/intgr) in [typeddjango/django-stubs#2049 - Refine return type for `ManyToOneRel.get_accessor_name()` by [@​mthuurne](https://togithub.com/mthuurne) in [typeddjango/django-stubs#2052 - Add `DeferredAttribute.__get__()` by [@​mthuurne](https://togithub.com/mthuurne) in [typeddjango/django-stubs#2050 - Add missing methods and superclass to `FieldFile` by [@​mthuurne](https://togithub.com/mthuurne) in [typeddjango/django-stubs#2051 - Add `db_comment=` parameter to Postgres and GIS model fields by [@​saJaeHyukc](https://togithub.com/saJaeHyukc) in [typeddjango/django-stubs#2054 - Correct type for `db.models.sql.query.Query.join()` argument by [@​mthuurne](https://togithub.com/mthuurne) in [typeddjango/django-stubs#2055 - 5.0: Update `django.db.backends.oracle.base` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2057 - 5.0: Update `django.test.client` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2059 - 5.0: Update `django.test.html` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2060 - 5.0: Update `django.test.runner` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2061 - 5.0: Update `django.template`, `django.templatetags` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2063 - 5.0: Update `django.test.testcases` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2062 - 5.0: Update `django.http` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2064 - 5.0: Update `django.core.management` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2067 - 5.0: Update `django.core.handlers` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2066 - 5.0: Update `django.contrib.sessions.serializers`, `django.core.serializers` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2068 - Update django app related types by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2071 - Add a `returncode` attribute to `CommandError` by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#2072 - Disable mypy `ignore_missing_imports` option by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2058 - fix typing for URL validator.**call** by [@​asottile](https://togithub.com/asottile) in [typeddjango/django-stubs#2074 - Use field generic types for descriptors by [@​md384](https://togithub.com/md384) in [typeddjango/django-stubs#2048 - 5.0: Update `django.core.servers.basehttp` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2070 - Update `django.template.base.Template.render()` argument type by [@​Majsvaffla](https://togithub.com/Majsvaffla) in [typeddjango/django-stubs#1160 - 5.0: Add `django.utils.choices` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2075 - 5.0: Update `django.contrib.sitemaps`, `django.contrib.staticfiles` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2076 - Update pyright report options (`reportMissingTypeArgument`, `reportPrivateUsage`) by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2077 - 5.0: Update `django.contrib.postgres` by [@​sudosubin](https://togithub.com/sudosubin) in [typeddjango/django-stubs#2078 - Add `path` signature for async views by [@​jlost](https://togithub.com/jlost) in [typeddjango/django-stubs#2085 - Remove incorrect `Reversible` base class from `QuerySet` by [@​intgr](https://togithub.com/intgr) in [typeddjango/django-stubs#2094 - Version 5.0.0 release (django-stubs, django-stubs-ext) by [@​flaeppe](https://togithub.com/flaeppe) in [typeddjango/django-stubs#2087 #### New Contributors - [@​Viicos](https://togithub.com/Viicos) made their first contribution in [typeddjango/django-stubs#1866 - [@​dephiros](https://togithub.com/dephiros) made their first contribution in [typeddjango/django-stubs#1873 - [@​jamesbraza](https://togithub.com/jamesbraza) made their first contribution in [typeddjango/django-stubs#1927 - [@​mfosterw](https://togithub.com/mfosterw) made their first contribution in [typeddjango/django-stubs#1943 - [@​palfrey](https://togithub.com/palfrey) made their first contribution in [typeddjango/django-stubs#1944 - [@​yhay81](https://togithub.com/yhay81) made their first contribution in [typeddjango/django-stubs#1955 - [@​delfick](https://togithub.com/delfick) made their first contribution in [typeddjango/django-stubs#1961 - [@​SingingTree](https://togithub.com/SingingTree) made their first contribution in [typeddjango/django-stubs#1956 - [@​avoronov-box](https://togithub.com/avoronov-box) made their first contribution in [typeddjango/django-stubs#1962 - [@​cuu508](https://togithub.com/cuu508) made their first contribution in [typeddjango/django-stubs#1993 - [@​samueljsb](https://togithub.com/samueljsb) made their first contribution in [typeddjango/django-stubs#1994 - [@​pelme](https://togithub.com/pelme) made their first contribution in [typeddjango/django-stubs#1999 - [@​mlazar-endear](https://togithub.com/mlazar-endear) made their first contribution in [typeddjango/django-stubs#2001 - [@​j00bar](https://togithub.com/j00bar) made their first contribution in [typeddjango/django-stubs#2010 - [@​jorenham](https://togithub.com/jorenham) made their first contribution in [typeddjango/django-stubs#2019 - [@​fidoriel](https://togithub.com/fidoriel) made their first contribution in [typeddjango/django-stubs#1925 - [@​armanckeser](https://togithub.com/armanckeser) made their first contribution in [typeddjango/django-stubs#2021 - [@​nebiyuelias1](https://togithub.com/nebiyuelias1) made their first contribution in [typeddjango/django-stubs#2029 - [@​Skorpyon](https://togithub.com/Skorpyon) made their first contribution in [typeddjango/django-stubs#1876 - [@​saJaeHyukc](https://togithub.com/saJaeHyukc) made their first contribution in [typeddjango/django-stubs#2054 - [@​sudosubin](https://togithub.com/sudosubin) made their first contribution in [typeddjango/django-stubs#2057 - [@​md384](https://togithub.com/md384) made their first contribution in [typeddjango/django-stubs#2048 - [@​Majsvaffla](https://togithub.com/Majsvaffla) made their first contribution in [typeddjango/django-stubs#1160 - [@​jlost](https://togithub.com/jlost) made their first contribution in [typeddjango/django-stubs#2085 **Full Changelog**: typeddjango/django-stubs@4.2.7...5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/libretime/libretime). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJweXRob24iXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1495 updated
get_field_related_model_clsto raiseUnregisteredModelErrorrather than returningNonefor failure paths. However, None can still be returned if the initial retrieval ofrelated_model_clsreturns None.This patch adds a check to see if the initial retrieval has got a
Noneand then raises the appropriate error rather than lettingNonebe returned.Related issues
Closes #1953