Add django.forms.widgets.FILE_INPUT_CONTRADICTION symbol #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Oct 28, 2020
| @@ -71,6 +71,8 @@ class HiddenInput(Input): | |||
| class MultipleHiddenInput(HiddenInput): ... | |||
| class FileInput(Input): ... | |||
|
|
|||
| FILE_INPUT_CONTRADICTION: Any | |||
There was a problem hiding this comment.
I was following the example of other some other sentinel objects. For example:
https://github.com/django/django/blob/302caa40e4caab7d95ef7d0a88a90f935039ab09/django/db/models/fields/mixins.py#L3
I could not find any examples in django-stubs of these sorts of sentinel objects being annotated as : object.
I can change this, if you think it should be object.
sobolevn
approved these changes
Oct 28, 2020
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/django/django/blob/302caa40e4caab7d95ef7d0a88a90f935039ab09/django/forms/widgets.py#L399