Missing Django 3.1 items #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkurnikov have you seen our discussion in #439 Glad to see you 🙂 |
|
For the PR this comment #439 (comment) is valid, it doesn't break anything. For the general case, I see this comment #439 (comment), is there anything done in that direction that I can look at? |
It might be a good way to go, because more and more users are reporting this.
No, this requires a lot of work, I didn't have the time for it. |
sobolevn
reviewed
Jan 19, 2021
| def get_internal_type(self): ... | ||
| def get_prep_value(self, value: Any): ... | ||
| def get_transform(self, name: Any): ... | ||
| def validate(self, value: Any, model_instance: Any) -> None: ... | ||
| def value_to_string(self, obj: Any): ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #556