feat: adds tests and docs for @deepkit/type #602
Conversation
smolinari
changed the title
hasezoey
added
docs
There was a problem hiding this comment.
Thanks for the documentation about @deepkit/type
there are some things needing to be fixed in this pr:
- please resolve the merge conflicts (currently
package.json) - please remove
package-lock.jsonand use yarn - maybe re-commit with a signed / registered commit (like 9f2160a)
|
@hasezoey - I have to ask the stupid question, what is a signed / registered commit? Scott |
sorry if i have put it weirdly, i meant for you to either:
and i ask this because it seems your current commit in this PR is not "linked" to your account (also, to have it accounted into one contributor in the git log) Note: this is just a suggestion, because i have seen it done previously in the mentioned commit |
|
@hasezoey - I got the GPG key going. Funny thing is, I'm certain I didn't have that when I did the other PR. I'm also not sure why there are these conflicts. What am I doing wrong? 🤔 Scott |
the second commit in this PR has now a signature, but it does not seem like it is added to your account (so it is unverified)
maybe you did the commit with the github web interface? and as for the current commits not being accounted / linking to your account is probably because no email that is also used for your github is provided in the commits Edit:
your current beta (this branch) seems to be based on a |
|
I've gotten the commit to be verified. What would you like me to do now though? 😁 Scott |
|
I have no clue, if I did it right or not. Very new to rebasing. 🤷 If not, I'll close this PR and start a new one on a fresh fork. Scott |
|
yes it seems like you rebased onto the upstream do you want me to rebase this branch? |
|
Rebased onto latest upstream |
Codecov Report
@@ Coverage Diff @@
## beta #602 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 17 17
Lines 839 839
Branches 222 222
=======================================
Hits 788 788
Misses 48 48
Partials 3 3 Continue to review full report at Codecov.
|
|
also changed commiter info if the first commit (to be the same as the later ones) PS: also thanks to the rebase re-commiting the commits they are now signed with my key (you are the author, i am the commiter - see this stackoverflow question) |
|
if you have problems updating your local branch, run (while being in the branch of this pr) |
@hasezoey - I'd like to do this, but like I mentioned above, my repo is borked. What would you suggest I should so as not to mess things up even more? Scott |
…trings where not needed
… too" is referring to
There was a problem hiding this comment.
everything now looks fine, @smolinari are you fine with the changes and how the documentation looks?
(you can run docusaurus manually, see website/README)
There was a problem hiding this comment.
again, everything looks still fine, @smolinari are you fine with the changes and how the documentation looks?
(you can run docusaurus manually, see website/README)
|
🎉 This PR is included in version 9.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds tests and some documentation for using @deepkit/type with Typegoose for serialization and deserialization.
Related Issues
Scott