Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed api to use https if coming from secure site. #31

Merged
merged 1 commit into from
Jun 17, 2011

Conversation

bee525
Copy link
Contributor

@bee525 bee525 commented Jun 17, 2011

No description provided.

@seanami
Copy link
Contributor

seanami commented Jun 17, 2011

This looks good to me! Thanks for the pull request.

One other way to do this that's a little bit shorter is to use a protocol-relative url. Souders has written about them, and they work in all browsers for JS urls. (There can be a double request for CSS urls, but that doesn't matter here.) http://www.stevesouders.com/blog/2010/02/10/5a-missing-schema-double-download/

I think this change is fine, just wanted to point that out as another option.

@bee525
Copy link
Contributor Author

bee525 commented Jun 17, 2011

I copied the code from:
webfontloader / src / google / fontapiurlbuilder.js

and just pasted it in. I do like the protocol-relative url idea, but didn't think you'd want to have two different ways of doing this in the same code base.

Thanks!

@seanami
Copy link
Contributor

seanami commented Jun 17, 2011

Yep, I agree. Was just as an FYI. I'll try to get this merged in soon.

seanami pushed a commit that referenced this pull request Jun 17, 2011
changed api to use https if coming from secure site.
@seanami seanami merged commit f3de6d4 into typekit:master Jun 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants