Fix/replace incorrent "racePair derives race" law #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I introduced an incorrect law for
race
.The problem in cats-effect's test is that the IOs aren't non-deterministic enough and we can't fix it unless we introduce a
Timer
inArbitrary[IO]
.This problem was caught by Monix's tests for
Task
, becauseArbitrary[Task]
does generate tasks with arbitrary time delays.So this law is incorrect because it expects a deterministic result and the whole point of
race
is precisely its non-determinism.