Fix starvation demo app in tuning guide #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Oct 23, 2023
Comment on lines
-32
to
+35
| IO.println(s"running #$i") >> IO(Thread.sleep(10000)) | ||
| IO { | ||
| println(s"running #$i") | ||
| Thread.sleep(10000) | ||
| } |
There was a problem hiding this comment.
Alternatively we could insert an IO.cede in-between the two IOs.
There was a problem hiding this comment.
Leaving out IO.cede keeps the example simpler for the broader public.
durban
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo actually wasn't starving because the fiber remained on the blocking thread it was shunted to for the preceding
IO.println.Further reading: https://typelevel.org/cats-effect/docs/faq#why-is-my-io-running-on-a-blocking-thread
h/t @felher