Add "repeated asyncF evaluation not memoized" law

[kubukoz]

I thought it would be reasonable to check that.

It's easy to break this law, for example by removing the suspend call here: https://github.com/kubukoz/slick-effect/blob/3af6c4ab8950f42ebbcaaed0fc5621c503bb258a/src/main/scala/slickeffect/DBIOAsync.scala#L27. That would memoize the promise, and it would only be completed once.

[codecov-io]

Codecov Report

Merging #473 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage    89.6%   89.66%   +0.06%     
==========================================
  Files          70       70              
  Lines        2020     2032      +12     
  Branches      202      197       -5     
==========================================
+ Hits         1810     1822      +12     
  Misses        210      210

[alexandru]

Note that this law probably breaks binary compatibility for Scala 2.11.

We can live with it for laws, but I'm not seeing Mima rules.

[kubukoz]

MiMa after enabling it in laws:

[error]  * method repeatedAsyncFEvaluationNotMemoized(java.lang.Object,scala.Function1)cats.kernel.laws.IsEq in trait cats.effect.laws.AsyncLaws is present only in current version
[error]    filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("cats.effect.laws.AsyncLaws.repeatedAsyncFEvaluationNotMemoized")
[error]  * method bracketPropagatesTransformerEffects(cats.arrow.FunctionK,java.lang.Object,scala.Function1,scala.Function1)cats.kernel.laws.IsEq in trait cats.effect.laws.BracketLaws is present only in current version
[error]    filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("cats.effect.laws.BracketLaws.bracketPropagatesTransformerEffects")
[error]  * method bracketTrans(cats.arrow.FunctionK,org.scalacheck.Arbitrary,cats.kernel.Eq,org.scalacheck.Arbitrary,cats.kernel.Eq,org.scalacheck.Arbitrary,org.scalacheck.Arbitrary,org.scalacheck.Arbitrary,org.scalacheck.Cogen,cats.kernel.Eq)org.typelevel.discipline.Laws#RuleSet in trait cats.effect.laws.discipline.BracketTests is present only in current version
[error]    filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("cats.effect.laws.discipline.BracketTests.bracketTrans")
[error] java.lang.RuntimeException: cats-effect-laws: Binary compatibility check failed!

Is it fine if I add all of them to exclusions?