Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string unmap with Parser1 #122

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Conversation

regadas
Copy link
Collaborator

@regadas regadas commented Dec 19, 2020

Just noticed that for string it unmap'ing 2 times. not sure if I'm missing anything.

@codecov-io
Copy link

Codecov Report

Merging #122 (d682675) into main (15d42dd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files           6        6           
  Lines         758      758           
  Branches       77       77           
=======================================
  Hits          717      717           
  Misses         41       41           
Impacted Files Coverage Δ
core/shared/src/main/scala/cats/parse/Parser.scala 95.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d42dd...d682675. Read the comment docs.

@johnynek johnynek merged commit 3e79914 into typelevel:main Dec 20, 2020
@johnynek
Copy link
Collaborator

Thanks!

@regadas regadas deleted the string_unmap branch December 20, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants