Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Data Type list fix #1497

Merged
merged 1 commit into from
Dec 18, 2016
Merged

Docs Data Type list fix #1497

merged 1 commit into from
Dec 18, 2016

Conversation

DanielaSfregola
Copy link
Contributor

At present, the documentation page for data types has a list of all the available data types: in this bullet list, the "Data Types" page itself is listed (see attached image).

datatype-bug

This PR fixes the generation of the data type bullet list, so that "Data Type" is no longer listed as a valid data type.

@codecov-io
Copy link

codecov-io commented Dec 13, 2016

Current coverage is 91.93% (diff: 100%)

Merging #1497 into master will not change coverage

@@             master      #1497   diff @@
==========================================
  Files           244        244          
  Lines          3621       3621          
  Methods        3502       3498     -4   
  Messages          0          0          
  Branches        119        123     +4   
==========================================
  Hits           3329       3329          
  Misses          292        292          
  Partials          0          0          

Powered by Codecov. Last update 73a6481...34eb2b4

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I am thinking can you try

{% if x.section == 'data' and x.title != page.title %}

instead of hard coding the title?

@kailuowang
Copy link
Contributor

closing and reopen to trigger the build again.

@DanielaSfregola
Copy link
Contributor Author

Great suggestion of using page.title instead of the hard-coded value! I have updated the code. Please, review.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@peterneyens peterneyens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@fthomas fthomas merged commit f4d47af into typelevel:master Dec 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants