Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use package object convention for object source path #1917

Merged
merged 1 commit into from
Sep 18, 2017

Conversation

travisbrown
Copy link
Contributor

The cats.implicits object is just an ordinary Scala object, not a package object, but its source path follows the convention for a package object. This causes problems on the latest version of Bazel, where the Scala compiler gets confused by the presence of the -sources jar and complains that "package cats contains object and package with same name: implicits".

Thanks to @ianoc-stripe for tracking this down, and for proposing a fix on the Bazel side. There's not really any reason for Cats to do this in the first place, though, and this PR simply moves the file so that the source jar doesn't end up with a cats/implicits directory. This is 100% compatible and shouldn't have any affect on anything except build tools that for whatever reason feed source jars to the Scala compiler.

@kailuowang
Copy link
Contributor

Thank you @travisbrown. No idea why it was set up that way.

@johnynek
Copy link
Contributor

👍

@codecov-io
Copy link

codecov-io commented Sep 18, 2017

Codecov Report

Merging #1917 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1917   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files         248      248           
  Lines        4420     4420           
  Branches      124      124           
=======================================
  Hits         4223     4223           
  Misses        197      197

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063be36...4e4bea8. Read the comment docs.

@kailuowang kailuowang merged commit c2f6ee4 into typelevel:master Sep 18, 2017
@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Oct 13, 2017
@kailuowang kailuowang added the bug label Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants