Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctest examples for Apply #2086

Merged
merged 2 commits into from
Dec 19, 2017
Merged

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Dec 9, 2017

No description provided.

@kailuowang
Copy link
Contributor

What's your opinion over #2083?

@codecov-io
Copy link

codecov-io commented Dec 9, 2017

Codecov Report

Merging #2086 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2086   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files         325      325           
  Lines        5511     5511           
  Branches      207      207           
=======================================
  Hits         5215     5215           
  Misses        296      296
Impacted Files Coverage Δ
core/src/main/scala/cats/Apply.scala 68.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8fb7ed...8f92f06. Read the comment docs.

@ceedubs ceedubs added the on hold label Dec 9, 2017
@ceedubs
Copy link
Contributor Author

ceedubs commented Dec 9, 2017

Thanks for pointing that out @kailuowang. I just left a comment on #2083. I think that we should get that one in first since it has the incompatible changes. I can update this PR afterwards.

@kailuowang
Copy link
Contributor

#2083 is merged

@ceedubs
Copy link
Contributor Author

ceedubs commented Dec 18, 2017

I should be able to update this today.

@ceedubs
Copy link
Contributor Author

ceedubs commented Dec 18, 2017

I've merged in the changes from master and resolved the conflicts.

@kailuowang kailuowang merged commit a2310b3 into typelevel:master Dec 19, 2017
@kailuowang kailuowang modified the milestones: 1.0.0-RC2, 1.0 Dec 19, 2017
LukaJCB pushed a commit that referenced this pull request Dec 19, 2017
* Add grouping to scaladoc for arity methods

This makes it so when you look at the `Applicative` scaladoc you don't
have a bunch of `ap3`, `ap4`, etc noise mixed in with the more
meaningful methods. Instead, the generated higher-arity methods show up
in separate scaladoc groups below.

To see the changes you can pull this branch, run `sbt unidoc` (you may
need to clean first), and open
`cats/docs/target/scala-2.12/unidoc/cats/Applicative.html` in your
browser.

* Add doctest examples for Apply (#2086)

* Get ready for RC2 (#2044)

* Draft release notes

* Update

* Update

* Update

* Update

* Update

* Update Authors

* Update

* Update

* Update

* Update

* update

* Update

* Update CHANGES.md

* Update AUTHORS.md

* Update README.md

* Update deprecations to product{L,R} instead of ap{L,R}
kailuowang added a commit that referenced this pull request Feb 2, 2018
* Setting version to 1.0.0-RC2

* Setting version to 1.0.0-SNAPSHOT

* Update deprecations to product{L,R} instead of ap{L,R} (#2121)

* Add grouping to scaladoc for arity methods

This makes it so when you look at the `Applicative` scaladoc you don't
have a bunch of `ap3`, `ap4`, etc noise mixed in with the more
meaningful methods. Instead, the generated higher-arity methods show up
in separate scaladoc groups below.

To see the changes you can pull this branch, run `sbt unidoc` (you may
need to clean first), and open
`cats/docs/target/scala-2.12/unidoc/cats/Applicative.html` in your
browser.

* Add doctest examples for Apply (#2086)

* Get ready for RC2 (#2044)

* Draft release notes

* Update

* Update

* Update

* Update

* Update

* Update Authors

* Update

* Update

* Update

* Update

* update

* Update

* Update CHANGES.md

* Update AUTHORS.md

* Update README.md

* Update deprecations to product{L,R} instead of ap{L,R}

* Setting version to 1.0.0

* Setting version to 1.0.1-SNAPSHOT

* Setting version to 1.0.1

* Setting version to 1.0.2-SNAPSHOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants