Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split build jvm,add workers to kernel #2189

Merged
merged 4 commits into from Mar 14, 2018
Merged

split build jvm,add workers to kernel #2189

merged 4 commits into from Mar 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 11, 2018

Also tweaked the cache in travis, including - $HOME/.cache for javascript build artifacts

@codecov-io
Copy link

codecov-io commented Mar 11, 2018

Codecov Report

Merging #2189 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2189      +/-   ##
==========================================
- Coverage   94.75%   94.73%   -0.03%     
==========================================
  Files         330      330              
  Lines        5568     5582      +14     
  Branches      201      207       +6     
==========================================
+ Hits         5276     5288      +12     
- Misses        292      294       +2
Impacted Files Coverage Δ
core/src/main/scala/cats/data/WriterT.scala 91.37% <0%> (-1.76%) ⬇️
...rc/main/scala/cats/laws/discipline/Arbitrary.scala 100% <0%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39b856...5ce1019. Read the comment docs.

build.sbt Outdated

addCommandAlias("buildTestingJVM", ";kernelLawsJVM/test;lawsJVM/test;testkitJVM/test;testsJVM/test")

addCommandAlias("buildJVM", ";macrosJVM/test;kernelJVM/test;buildTestingJVM;jvm/test;coreJVM/test;freeJVM/test;buildAlleycatsJVM")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry to nitpick, but this gets harder for me to track what's included in what. maybe we break out a "buildKernelJVM" and a "buildFreeJVM" too for the sake of a clearer structure? Just a thought.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh. I originally had:

-addCommandAlias("buildJVM", ";macrosJVM/test;kernelJVM/test;kernelLawsJVM/test;lawsJVM/test;testkitJVM/test;testsJVM/test;jvm/test;coreJVM/test;freeJVM/test;alleycatsCoreJVM/test;alleycatsLawsJVM/test;alleycatsTestsJVM/test")

Ha! Not a problem to break up more, it's more confusing than it should be whatever we do, so I thought I should PR something to get some thoughts. I'll update it now.

@ghost
Copy link
Author

ghost commented Mar 12, 2018

Those two codecov are from #2182, merged two hours ago

@johnynek
Copy link
Contributor

seems fine to me, but does not seem to have sped up the build. was there another goal?

@ghost
Copy link
Author

ghost commented Mar 12, 2018

seems fine to me, but does not seem to have sped up the build. was there another goal?

Speed was not the issue, rather OOM in CI - eg see https://travis-ci.org/BennyHill/cats/jobs/352007704 and chat in gitter before and after https://gitter.im/typelevel/cats-dev?at=5aa55b886f8b4b994614b5c0

Original chat: https://gitter.im/typelevel/cats?at=5a99c17235dd17022e141d21

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kailuowang kailuowang requested a review from LukaJCB March 14, 2018 00:47
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ceedubs ceedubs merged commit e3a12ef into typelevel:master Mar 14, 2018
@kailuowang kailuowang added this to the 1.1 milestone Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants