Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poly lambda syntax in FreeApplicative test #2213

Merged
merged 3 commits into from
Mar 26, 2018

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Mar 25, 2018

This is the last explicit new FunctionK that I saw in the code base
when I looked to close out #1374.

This is the last explicit `new FunctionK` that I saw in the code base
when I looked to close out typelevel#1374.
@codecov-io
Copy link

codecov-io commented Mar 25, 2018

Codecov Report

Merging #2213 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2213     +/-   ##
=========================================
+ Coverage   94.83%   95.04%   +0.2%     
=========================================
  Files         333      333             
  Lines        5789     5789             
  Branches      211      211             
=========================================
+ Hits         5490     5502     +12     
+ Misses        299      287     -12
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/vector.scala 100% <0%> (+27.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f3ea43...f2f23f9. Read the comment docs.

johnynek
johnynek previously approved these changes Mar 25, 2018
@peterneyens
Copy link
Collaborator

There are a few more using ~> in CofreeSuite.

@ceedubs
Copy link
Contributor Author

ceedubs commented Mar 25, 2018

Good catch @peterneyens. Updated.

@peterneyens
Copy link
Collaborator

Sorry for not linking to them in my previous comment, but there are also toList and inclusion in CofreeSuite. (inclusion could be OptionT.liftK[Eval] I think).

@ceedubs
Copy link
Contributor Author

ceedubs commented Mar 26, 2018

@peterneyens yet another good catch. Updated again.

@johnynek johnynek merged commit 1f8e5d9 into typelevel:master Mar 26, 2018
@stew stew removed the in progress label Mar 26, 2018
@kailuowang kailuowang added this to the 1.2 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants