Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bitraverse docs #2291

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Conversation

Zelenya
Copy link
Contributor

@Zelenya Zelenya commented Jun 10, 2018

  • update bisequence doc (not sure if it got any better)
  • add bitraverse doctest example

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

@codecov-io
Copy link

codecov-io commented Jun 10, 2018

Codecov Report

Merging #2291 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2291      +/-   ##
==========================================
+ Coverage   94.97%   95.01%   +0.03%     
==========================================
  Files         337      337              
  Lines        5832     5832              
  Branches      217      217              
==========================================
+ Hits         5539     5541       +2     
+ Misses        293      291       -2
Impacted Files Coverage Δ
core/src/main/scala/cats/Bitraverse.scala 80% <ø> (ø) ⬆️
core/src/main/scala/cats/syntax/bitraverse.scala 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3993dba...339b1f7. Read the comment docs.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zelenya!

I could see there being some merit in using different types instead of both inputs being Int and both outputs being Option[Int] to make it clear that this works on different types. But I think that this is a simple example and it's a nice addition.

@ceedubs ceedubs merged commit f439fe0 into typelevel:master Jun 11, 2018
@Zelenya
Copy link
Contributor Author

Zelenya commented Jun 11, 2018

@ceedubs yeah, I've initially did parseInt and parseBoolean, but those preparations took more space than example itself.

@Zelenya Zelenya deleted the bitraverse-update-docs branch June 11, 2018 16:15
@kailuowang kailuowang added this to the 1.2 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants