Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unconventional package objects in kernel #2785

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Fix unconventional package objects in kernel #2785

merged 3 commits into from
Apr 11, 2019

Conversation

denisrosca
Copy link
Contributor

Closes #2781

kailuowang
kailuowang reviewed Apr 10, 2019
View reviewed changes
kernel/src/main/scala/cats/kernel/instances/eq/package.scala Outdated

object eq extends EqInstances
trait EqInstances extends EqToEquivConversion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this change is necessary

kailuowang
kailuowang reviewed Apr 10, 2019
View reviewed changes
kernel/src/main/scala/cats/kernel/instances/hash/package.scala Outdated

object hash extends HashInstances
trait HashInstances extends HashToHashingConversion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. the original is fine IMO

@kailuowang
Copy link
Contributor

thanks so much! I think we should leave those existing non-package object alone.

@denisrosca
Copy link
Contributor Author

I'll revert the changes breaking binary compatibility and keep the rest.

@denisrosca
Copy link
Contributor Author

@kailuowang any idea what happened with the 2.12.7 build? It looks like it never actually completed.

kailuowang
kailuowang approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@kailuowang
Copy link
Contributor

Sometimes it hangs. I just restarted it, should be green soon

@kailuowang kailuowang merged commit d340d1d into typelevel:master Apr 11, 2019
@kailuowang kailuowang mentioned this pull request Apr 13, 2019
Open
@kailuowang kailuowang added this to the 2.0.0-M1 milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailuowang kailuowang kailuowang approved these changes

@LukaJCB LukaJCB LukaJCB approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.

unconventional package objects
3 participants
@denisrosca @kailuowang @LukaJCB