Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2891 - Ambiguous Vector instances #3100

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Issue 2891 - Ambiguous Vector instances #3100

merged 2 commits into from
Oct 18, 2019

Conversation

barambani
Copy link
Contributor

Fixes #2891

@codecov-io
Copy link

codecov-io commented Oct 5, 2019 •
edited
Loading

Codecov Report

Merging #3100 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3100   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files         368      368           
  Lines        6983     6983           
  Branches      195      195           
=======================================
  Hits         6529     6529           
  Misses        454      454
Impacted Files Coverage Δ
...n/scala/cats/kernel/instances/QueueInstances.scala 100% <100%> (ø) ⬆️
...in/scala/cats/kernel/instances/ListInstances.scala 100% <100%> (ø) ⬆️
.../scala/cats/kernel/instances/VectorInstances.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update befc276...4afb3a3. Read the comment docs.

kailuowang
kailuowang approved these changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

kailuowang
kailuowang approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LukaJCB LukaJCB merged commit e766998 into typelevel:master Oct 18, 2019
@barambani
Copy link
Contributor Author

My pleasure, thank you 😄

@barambani barambani deleted the issue-2891 branch October 18, 2019 18:42
@travisbrown travisbrown added the bug label Nov 6, 2019
@travisbrown travisbrown added this to the 2.1.0-RC1 milestone Nov 6, 2019
This was referenced Nov 13, 2019
Closed
Merged
travisbrown added a commit to travisbrown/cats that referenced this pull request Nov 19, 2019
@travisbrown
Revert "Issue 2891 - Ambiguous Vector instances (typelevel#3100)"
d1e1277 
This reverts commit e766998.
@travisbrown travisbrown mentioned this pull request Nov 19, 2019
Merged
rossabaker pushed a commit that referenced this pull request Nov 26, 2019
@travisbrown @rossabaker
Fix broken binary compatibility (#3163)
6697edc 
* Revert "Issue 2891 - Ambiguous Vector instances (#3100)"

This reverts commit e766998.

* Revert "Changed precedence of tupled instances for Hash and PartialOrder (#3105)"

This reverts commit 6e7ff8f.

* Move method back to avoid bincompat breakage

* Reinstate doc fix from #3105
@travisbrown travisbrown mentioned this pull request Nov 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailuowang kailuowang kailuowang approved these changes

@LukaJCB LukaJCB LukaJCB approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1.0-RC1
Development

Successfully merging this pull request may close these issues.

Ambiguous Vector instances
5 participants
@barambani @codecov-io @kailuowang @LukaJCB @travisbrown