Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Align for Stream #3144

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Conversation

travisbrown
Copy link
Contributor

Follow-up to #3076 adding Align[Stream] with the same implementation as Align[LazyList]. I don't think there's any reason not to include these, @LukaJCB?

I've also added a package-private Align.alignWithIterator helper method to clean up some repetition in Align definitions.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Just a simple oversight on my end

@travisbrown
Copy link
Contributor Author

Great, thanks @LukaJCB!

@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #3144 into master will decrease coverage by 2.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3144      +/-   ##
==========================================
- Coverage   93.28%   90.93%   -2.35%     
==========================================
  Files         376      375       -1     
  Lines        7323     7300      -23     
  Branches      174      189      +15     
==========================================
- Hits         6831     6638     -193     
- Misses        492      662     +170
Flag Coverage Δ
#scala_version_212 ?
#scala_version_213 90.93% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
...src/main/scala-2.13+/cats/instances/lazyList.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/Align.scala 76.47% <100%> (-23.53%) ⬇️
core/src/main/scala/cats/syntax/ior.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/nested.scala 0% <0%> (-100%) ⬇️
...re/src/main/scala/cats/syntax/traverseFilter.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/set.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/TrySyntax.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/function1.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/eitherK.scala 0% <0%> (-100%) ⬇️
core/src/main/scala/cats/syntax/option.scala 30% <0%> (-70%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffded4b...a79b08e. Read the comment docs.

@travisbrown travisbrown merged commit 9bb9636 into typelevel:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants