Move State companion to the package object #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So just to be clear, people can still reference it as |
|
Yes and yes. The value alias in the package object allows us to use the name |
|
👍 thanks! |
|
An alternative would be: package object state {
type State = ...
object State extends StateCompanion
}
// State.scala
class StateCompanion { ... }That way, the ugly name |
As it stands, `State` causes strange behaviors like State.apply working the first time, but failing the second time to find apply. @retronym pointed to me to SI-7139, which says that the REPL gets confused about the type when there's a type alias and an object named the same. This adds the workaround to SI-7139 by moving State companion into the package object.
eed3si9n
force-pushed
the
topic/state-repl-workaround
branch
from
37bf89a
to
091f1ba
Compare
|
Pushed in a new commit with the |
eed3si9n
changed the title
|
I just ran into the same issue with |
|
👍 I had done something very similar in a follow-up State branch that it looks like I never turned into a PR. I'll try to come back to that soon. |
stew
added a commit
that referenced
this pull request
Jun 5, 2015
Move State companion to the package object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands,
Statecauses strange behaviors like State.apply workingthe first time, but failing the second time to find apply. See https://gist.github.com/eed3si9n/9804d496bfeb457282c2
@retronym pointed me to SI-7139, which says that the REPL gets
confused about the type when there's a type alias and an object named
the same.
This adds the workaround posted on SI-7139, which is to move the name
Stateinto package object.