Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functor - fproductLeft #3421

Merged
merged 2 commits into from
May 21, 2020
Merged

Functor - fproductLeft #3421

merged 2 commits into from
May 21, 2020

Conversation

pk044
Copy link
Contributor

@pk044 pk044 commented May 18, 2020

Closes #3414

@pk044 pk044 changed the title Functor - fProductLeft Functor - fproductLeft May 18, 2020
Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you :)

@codecov-io
Copy link

codecov-io commented May 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4465141). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3421   +/-   ##
=========================================
  Coverage          ?   92.71%           
=========================================
  Files             ?      379           
  Lines             ?     7987           
  Branches          ?      234           
=========================================
  Hits              ?     7405           
  Misses            ?      582           
  Partials          ?        0           
Flag Coverage Δ
#scala_version_212 92.74% <100.00%> (?)
#scala_version_213 92.50% <100.00%> (?)
Impacted Files Coverage Δ
core/src/main/scala/cats/Functor.scala 100.00% <100.00%> (ø)
kernel/src/main/scala/cats/kernel/Bounded.scala 8.33% <0.00%> (ø)
...ain/scala/cats/laws/discipline/TraverseTests.scala 100.00% <0.00%> (ø)
...a/cats/laws/discipline/ApplicativeErrorTests.scala 100.00% <0.00%> (ø)
...ws/src/main/scala/cats/laws/DistributiveLaws.scala 100.00% <0.00%> (ø)
...ts/laws/discipline/InvariantSemigroupalTests.scala 100.00% <0.00%> (ø)
...main/scala/cats/laws/discipline/FlatMapTests.scala 100.00% <0.00%> (ø)
kernel/src/main/scala/cats/kernel/Band.scala 50.00% <0.00%> (ø)
.../src/main/scala/cats/syntax/applicativeError.scala 77.77% <0.00%> (ø)
core/src/main/scala/cats/data/WriterT.scala 91.40% <0.00%> (ø)
... and 370 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4465141...409015f. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4465141). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3421   +/-   ##
=========================================
  Coverage          ?   92.71%           
=========================================
  Files             ?      379           
  Lines             ?     7987           
  Branches          ?      234           
=========================================
  Hits              ?     7405           
  Misses            ?      582           
  Partials          ?        0           
Flag Coverage Δ
#scala_version_212 92.74% <100.00%> (?)
#scala_version_213 92.50% <100.00%> (?)
Impacted Files Coverage Δ
core/src/main/scala/cats/Functor.scala 100.00% <100.00%> (ø)
...ain/scala/cats/kernel/instances/MapInstances.scala 100.00% <0.00%> (ø)
...la/cats/kernel/laws/CommutativeSemigroupLaws.scala 100.00% <0.00%> (ø)
core/src/main/scala/cats/arrow/Strong.scala 100.00% <0.00%> (ø)
...ain/scala/cats/laws/discipline/FoldableTests.scala 100.00% <0.00%> (ø)
...rc/main/scala/cats/laws/discipline/arbitrary.scala 99.14% <0.00%> (ø)
core/src/main/scala/cats/instances/parallel.scala 0.00% <0.00%> (ø)
core/src/main/scala/cats/data/EitherK.scala 94.54% <0.00%> (ø)
...main/scala/cats/laws/discipline/MonoidKTests.scala 100.00% <0.00%> (ø)
core/src/main/scala/cats/evidence/As.scala 100.00% <0.00%> (ø)
... and 370 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4465141...409015f. Read the comment docs.

@djspiewak djspiewak merged commit 2bb358d into typelevel:master May 21, 2020
@travisbrown travisbrown added this to the 2.2.0-M2 milestone May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a fproductLeft function to Functor
6 participants