Deprecate Simulacrum ops objects #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3442 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 381 381
Lines 8299 8299
Branches 216 216
=======================================
Hits 7606 7606
Misses 693 693 |
LukaJCB
previously approved these changes
May 30, 2020
|
Okay, this is rebased and updated now that Simulacrum Scalafix 0.3.0 is out and #3340 is merged, so it's ready for review! |
LukaJCB
approved these changes
May 31, 2020
|
@rossabaker or @mpilquist, mind a quick review since you okayed the idea in #3330? |
kailuowang
approved these changes
Jun 15, 2020
barambani
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3330 and depends on #3440 and this change in Simulacrum Scalafix.
Once this is approved (which shouldn't be a big deal since there are several sign-offs on #3330, and this is a pretty mechanical implementation) I'll publish Simulacrum Scalafix 0.3.0 with the two changes we need for this and #3440, then merge #3440 and rebase and merge this one.