Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MonoidK and SemigroupK instances for Function1 and also a Semigroup instance for Function1 #691

Merged
merged 5 commits into from
Nov 24, 2015

Conversation

lvicentesanchez
Copy link

This PR address #684 by adding MonoidK and SemigroupK instances for Function1; it also adds a Semigroup instance for Funcion1.

@codecov-io
Copy link

Current coverage is 83.93%

Merging #691 into master will increase coverage by +0.04% as of f68f4d0

@@            master    #691   diff @@
======================================
  Files          162     162       
  Stmts         2217    2222     +5
  Branches        74      74       
  Methods          0       0       
======================================
+ Hit           1860    1865     +5
  Partial          0       0       
  Missed         357     357       

Review entire Coverage Diff as of f68f4d0

Powered by Codecov. Updated on successful CI builds.

new Function1MonoidK {}
}

trait Function1Instances0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this private[std] sealed trait Function1Instances0 please? This will make it consistent with the work done in #612.

@ceedubs
Copy link
Contributor

ceedubs commented Nov 22, 2015

I left a couple very minor comments, but other than that, this looks great! Thank you.

@lvicentesanchez
Copy link
Author

Ok, that should do it :)

@ceedubs
Copy link
Contributor

ceedubs commented Nov 23, 2015

👍 looks great!

@non
Copy link
Contributor

non commented Nov 24, 2015

Thanks! 👍

non added a commit that referenced this pull request Nov 24, 2015
Add MonoidK and SemigroupK instances for Function1 and also a Semigroup instance for Function1
@non non merged commit 332006e into typelevel:master Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants