Set up Machinist, use macros for Eq through Order syntax. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds cats-macros, upon which cats depends.
Right now, the only macros being used are Machinist's
operator macros, which are configured in cats.macros.Ops.
The punchline of doing this is that:
def xyz[A: Eq](x: A, y: A): Boolean =
x === y
is now exactly the same as:
def xyz[A](x: A, y: A)(implicit A: Eq[A]): Boolean =
A.eqv(x, y)
i.e. the syntax implicit conversions are completely erased.
This eliminates the performance penalty that syntax normally
implies. It also means the syntax classes don't need to be
value classes (or specialized) since they are not used at
runtime.
|
(This fixes #78.) |
This commit: 1. Adds -language:experimental.macros 2. Removes a bunch of imports 3. Fixes the algebra -> cats type aliases
|
This looks good to me, so I'd be happy to have it merged and just close #80. |
|
oh oops, I just merged #80 |
|
@travisbrown @stew I think the commit I just pushed cleans it up. If this is green I think it's ready. |
|
👍 |
stew
added a commit
that referenced
this pull request
Feb 5, 2015
Set up Machinist, use macros for Eq through Order syntax.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds cats-macros, upon which cats depends.
Right now, the only macros being used are Machinist's
operator macros, which are configured in cats.macros.Ops.
The punchline of doing this is that:
is now exactly the same as:
i.e. the syntax implicit conversions are completely erased.
This eliminates the performance penalty that syntax normally
implies. It also means the syntax classes don't need to be
value classes (or specialized) since they are not used at
runtime.