Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove imports now that we have package-level aliases #80

Merged
merged 1 commit into from
Feb 5, 2015

Conversation

travisbrown
Copy link
Contributor

These are causing the build to fail both locally for me and on Travis.

@travisbrown
Copy link
Contributor Author

Oh, new commits just showed up—rebasing this now.

@travisbrown
Copy link
Contributor Author

We can't import algebra.Monoid in Foldable because of the type alias hiding, but we need the Monoid companion object there, not just the type. I've just used the fully-qualified name for the companion object, but that's probably not the best long-term solution (maybe a val Monoid in the package object?). My vote is that we can decide on that later and just fix the build for now.

@non
Copy link
Contributor

non commented Feb 5, 2015

Yes, in another PR I added aliases for the companions.

So once that lands we can change this (or vice versa). Sorry for the incomplete strategy.

@non
Copy link
Contributor

non commented Feb 5, 2015

I agree, 👍 on this for now.

@stew
Copy link
Contributor

stew commented Feb 5, 2015

yeah, this works for me now 👍

stew added a commit that referenced this pull request Feb 5, 2015
Remove imports now that we have package-level aliases
@stew stew merged commit d433113 into typelevel:master Feb 5, 2015
@stew stew removed the in progress label Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants