Add S3BatchEvent and S3BatchResult #231
Conversation
|
Thanks for the contribution! Looks like this needs |
|
Doesn't like 2022 copyright year, I guess 🙁 |
| implicit def kernelSource: KernelSource[S3BatchEvent] = KernelSource.emptyKernelSource | ||
| } | ||
|
|
||
| final case class S3BatchJob(id: String) |
There was a problem hiding this comment.
Seems it's called S3BatchEventJob in TS :)
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/d18a30127146217038c61060b06e96713daa706c/types/aws-lambda/trigger/s3-batch.d.ts#L17
| (r.invocationSchemaVersion, r.treatMissingKeysAs, r.invocationId, r.results)) | ||
| } | ||
|
|
||
| sealed trait S3BatchResultCode |
There was a problem hiding this comment.
Admittedly, it's kind of a crazy name 😂
| sealed trait S3BatchResultCode | |
| sealed abstract class S3BatchResultResultCode |
There was a problem hiding this comment.
No problem. Any reason why abstract class works better than trait here?
There was a problem hiding this comment.
Good question, in practice it will probably make no measurable difference. I prefer abstract class where possible because admittedly, superstition, 😂 I think it might be more performant to do isInstanceOf checks and stuff.
More interestingly, the new enum keyword in Scala 3 would let us define it like this as:
enum S3BatchResultResultCode:
case Succeeded, TemporaryFailure, PermanentFailureAnd behind-the-scenes, that is generating code equivalent to using an abstract class. So this approach is binary compatible with that syntax sugar.
There was a problem hiding this comment.
Gotcha, makes sense.
| type S3BatchLambdaEnv[F[_]] = LambdaEnv[F, S3BatchEvent] | ||
| type SnsLambdaEnv[F[_]] = LambdaEnv[F, SnsEvent] |
There was a problem hiding this comment.
Thanks for adding this missing one! :)
S3 batch ops event/result types. Cheers!