Add S3Event #354
Add S3Event #354
Conversation
|
|
||
| object S3EventRecord { | ||
|
|
||
| implicit private val instantDecoder: Decoder[Instant] = Decoder[String].map(Instant.parse(_)) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Probably, looks quite similar. I'll try, the test covers that.
There was a problem hiding this comment.
Yes, that works. Though, I had to keep the implicit val to prevent feral.lambda.events.instantDecoder from being used.
There was a problem hiding this comment.
Oh I see, there was a conflict with this one 🤔
feral/lambda/shared/src/main/scala/feral/lambda/events/package.scala
Lines 26 to 27 in cbd83ba
Maybe we should make that one not implicit 🤔 anyway, that can be a follow-up PR.
There was a problem hiding this comment.
#356 could be that follow-up (or preparation) PR for this one.
| } | ||
|
|
||
| final case class S3EventRecordGlacierRestoreEventData( | ||
| lifecycleRestorationExpiryTime: String, |
There was a problem hiding this comment.
Should this also be an Instant?
There was a problem hiding this comment.
Yes, according to Event message structure it's a time in ISO-8601 format as well.
This PR adds case classes and json-decoders for
S3Event. This allows S3 to trigger the lambda function as described here.