Optimize Chunk#toByteVector when backed by a ByteBuffer
#2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@armanbilge Can you give a quick summary of what would be the effect of this change? |
diesalbla
approved these changes
Jul 10, 2022
armanbilge
changed the title
toByteVector when backed by a ByteBufferChunk#toByteVector when backed by a ByteBuffer
mpilquist
reviewed
Jul 28, 2022
| case c: Chunk.ByteBuffer => | ||
| // if c is a view, position/limit of underlying buffer may have changed | ||
| val bb = c.buf.asReadOnlyBuffer() | ||
| bb.position(c.offset) |
There was a problem hiding this comment.
Do these need to take in to account the original position and limit as well? E.g. bb.position(bb.position + c.offset)
There was a problem hiding this comment.
I don't think so. bb.position() is not constant and bb.position(i) is not relative as far as I can make out.
There was a problem hiding this comment.
Okay got it, when we create a Chunk.ByteBuffer, we copy the position & limit in to offset & length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
Chunkis backed byByteBufferit is not necessary to copy the bytes to convert it to aByteVector. This PR implements the conversion by creating aByteVector"view" that directly wraps the chunk's underlyingByteBuffer.