Node.js Gzip #2953
Merged
Node.js Gzip #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Jul 27, 2022
Comment on lines
+61
to
+63
| modificationTime: Option[Nothing] = None, | ||
| fileName: Option[Nothing] = None, | ||
| comment: Option[Nothing] = None |
There was a problem hiding this comment.
Using Option[Nothing] keeps us source-compatible with JVM while only accepting None. Furthermore, thanks to type erasure it leaves the door open to add support for these in the future if Node.js ever gets them.
| @@ -82,6 +82,36 @@ abstract class CompressionSuite(implicit compression: Compression[IO]) extends F | |||
| ) | |||
| ) | |||
|
|
|||
| test("inflate please wrap") { | |||
There was a problem hiding this comment.
Added these tests because actually the existing Node.js inflate/deflate implementation was broken 😅
| ): Pipe[F, Byte, Byte] = deflateImpl(deflateParams) { options => | ||
| require(!deflateParams.fhCrcEnabled, "FHCRC is not supported on Node.js") | ||
| deflateParams.header match { | ||
| case ZLibParams.Header.GZIP => facade.zlib.createGzip(options) |
There was a problem hiding this comment.
Delegating to Node.js is as easy is this.
| else | ||
| facade.zlib.inflateSync(in, options) | ||
| Chunk.uint8Array(out).toArray | ||
| } | ||
|
|
||
| test("gzip |> gunzip ~= id") { |
There was a problem hiding this comment.
Frustratingly, these tests are cloned from the JVM suite except modified to remove the optional headers unsupported on Node.js. The duplication is unfortunate but I didn't see a clean way to share them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2771, with many apologies to @yurique for their heroic effort on that 🙏
In #2771 we attempted to cross-build the existing Gzip implementation on the JVM. Instead, this PR delegates directly to the Node.js Gzip implementation. This is better for performance and is much simpler to implement. However, we are unable to support the optional headers for filename, comment, and timestamp. Fortunately http4s does not require these in its Gzip middlewares.
There is an unfortunate amount of duplication of tests and scaladocs in this PR.