Weird interaction between cancelation and interruptWhen #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weird interaction between cancelation and interruptWhen
TimWSpence
changed the title
I believe that the `.as(canceledError)` is safe as our `fa.attempt` was canceled which means that cancelation is unmasked in this scope and hence `F.canceled.as(canceledError) <-> F.canceled`. This matches the behaviour in `Scope#interruptibleEval` when there is no interrupt context and it binds `fa.attempt` directly
Preserves previous behaviour
deferred.get should not error or be canceled
armanbilge
reviewed
Aug 11, 2022
| case Left(other) => Left(other) | ||
| F.raceOutcome(deferred.get, fa.attempt).flatMap { | ||
| case Right(oc) => | ||
| oc.embed(F.canceled.as(canceledError)).map(_.leftMap(Outcome.Errored(_))) |
There was a problem hiding this comment.
Just a nit, maybe we can write this with oc.fold(...) to save the two separate ops?
There was a problem hiding this comment.
Oh yep, good call 👍 Will fix tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hanging when combining
Stream.eval(F.canceled)andinterruptWhen.I believe that the
.as(canceledError)is safe as ourfa.attemptwas canceled which means that cancelation is unmasked in this scope and henceF.canceled.as(canceledError) <-> F.canceled. This matches the behaviour inScope#interruptibleEvalwhen there is no interrupt context and it bindsfa.attemptdirectly.