Optimize Chunk#to{Byte,Char}Buffer, add note about mutability
#3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Feb 19, 2023
Comment on lines
-315
to
+318
| val b = c.buf.asReadOnlyBuffer | ||
| val b = c.buf.duplicate // share contents, independent position/limit |
There was a problem hiding this comment.
asReadOnlyBuffer and duplicate are similar in that the returned buffer has independent position/limit.
The difference is that a read-only buffer denies access to its underlying Array, while a duplicated buffer does not. Being able to get at that array is an important optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some unsuspended uses of
toByteBufferwhich I am fixing in d76bdea.