Optimize fs2.text.{char2string,string2char}
#3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
changed the title
fs2.text.{chars2string,string2char}fs2.text.{char2string,string2char}
filipwiech
reviewed
Aug 15, 2023
| def char2string[F[_]]: Pipe[F, Char, String] = _.chunks.map(_.mkString_("")) | ||
| def char2string[F[_]]: Pipe[F, Char, String] = _.chunks.map { chunk => | ||
| val Chunk.ArraySlice(chars, offset, length) = chunk.toArraySlice | ||
| new String(chars, offset, length) |
There was a problem hiding this comment.
Would it be a good idea to use the UTF-8 charset instead of relying on the default one, like we do in a few other places where we create a new String (private val utf8Charset = Charset.forName("UTF-8"))? 🙂
There was a problem hiding this comment.
Hmm, not sure. Perhaps you are mixing up the ctor that takes an Array[Byte] with the one we are using here, which takes an Array[Char]?
There was a problem hiding this comment.
Ah, that's it, you're right, sorry for the confusion. 😅
filipwiech
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.